Skip to content

ref(router): Align route params with semantic conventions #16828

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 8, 2025
Merged

ref(router): Align route params with semantic conventions #16828

merged 2 commits into from
Jul 8, 2025

Conversation

s1gr1d
Copy link
Member

@s1gr1d s1gr1d commented Jul 7, 2025

@s1gr1d s1gr1d requested review from mydea and AbhiPrasad July 7, 2025 14:45
mydea
mydea approved these changes Jul 7, 2025
View reviewed changes
Copy link
Member

@mydea mydea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice! I do not quite understand the PR title, should this be "Align route params with semantic conventions" or something like this? 😅

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 7, 2025 •
edited
Loading

size-limit report 📦

Path Size % Change Change
@sentry/browser 23.99 kB - -
@sentry/browser - with treeshaking flags 23.76 kB - -
@sentry/browser (incl. Tracing) 39.59 kB - -
@sentry/browser (incl. Tracing, Replay) 77.77 kB - -
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags 70.85 kB - -
@sentry/browser (incl. Tracing, Replay with Canvas) 82.49 kB - -
@sentry/browser (incl. Tracing, Replay, Feedback) 94.65 kB - -
@sentry/browser (incl. Feedback) 40.75 kB - -
@sentry/browser (incl. sendFeedback) 28.7 kB - -
@sentry/browser (incl. FeedbackAsync) 33.59 kB - -
@sentry/react 25.76 kB - -
@sentry/react (incl. Tracing) 41.58 kB - -
@sentry/vue 28.37 kB - -
@sentry/vue (incl. Tracing) 41.38 kB +0.04% +15 B 🔺
@sentry/svelte 24.01 kB - -
CDN Bundle 25.5 kB - -
CDN Bundle (incl. Tracing) 39.6 kB - -
CDN Bundle (incl. Tracing, Replay) 75.58 kB - -
CDN Bundle (incl. Tracing, Replay, Feedback) 81.05 kB - -
CDN Bundle - uncompressed 74.5 kB - -
CDN Bundle (incl. Tracing) - uncompressed 117.63 kB - -
CDN Bundle (incl. Tracing, Replay) - uncompressed 231.92 kB - -
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed 244.75 kB - -
@sentry/nextjs (client) 43.22 kB - -
@sentry/sveltekit (client) 40.04 kB - -
@sentry/node 162.02 kB - -
@sentry/node - without tracing 98.64 kB - -
@sentry/aws-serverless 124.4 kB - -

View base workflow run

@s1gr1d s1gr1d changed the title ref(router): Save params aligning with semantic convention ref(router): Align route params with semantic conventions Jul 7, 2025
@s1gr1d s1gr1d merged commit f342341 into develop Jul 8, 2025
129 checks passed
@s1gr1d s1gr1d deleted the sig/semantic-conv-params branch July 8, 2025 07:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mydea mydea mydea approved these changes

@AbhiPrasad AbhiPrasad AbhiPrasad approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@s1gr1d @mydea @AbhiPrasad